Experimental: simplify data structs #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's undocumented side effect from the past. We promote using Marshal and Unmarshal which set/get values and do not link fields.
alovak
force-pushed
the
simplify-data-struct
branch
from
5d010c2 to
b657e60
Compare
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 73.70% 72.60% -1.10%
==========================================
Files 43 44 +1
Lines 2282 2351 +69
==========================================
+ Hits 1682 1707 +25
- Misses 369 412 +43
- Partials 231 232 +1
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
|
this PR was a proof of concept. Now all ideas are implemented in the module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to implement (now it's more like proof of concept) the proposal #277 to use go basic types in the data structs instead of
*field.String,*field.Numeric, etc. like this: